Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify amd64 platform to fix ov builds on macOS #4932

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Specify amd64 platform to fix ov builds on macOS #4932

merged 1 commit into from
Sep 16, 2024

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 16, 2024

Fixes

Fixes #4931 by @d3jawu

Description

This PR specifies ov to build and run a Linux amd64 image. This fixes builds breaking on macOS because the k6 RPM repo does not supply aarch64 builds which is the default architecture used unless specified with the --platform flag.

Testing Instructions

  1. Check out the PR.
  2. Try to build ov: ov build
  3. Try to initialize ov: ov init

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 16, 2024 05:13
@dhruvkb dhruvkb requested review from AetherUnbound and sarayourfriend and removed request for a team September 16, 2024 05:13
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Sep 16, 2024
@dhruvkb dhruvkb requested review from a team and obulat and removed request for AetherUnbound and a team September 16, 2024 05:24
@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 16, 2024 •
edited
Loading

I re-requested the reviewers from the @WordPress/openverse-maintainers group to pick a maintainer with a Mac, and one with Linux.

sarayourfriend
sarayourfriend approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... but does this mean ov itself will run under Rosetta for macOS folks now? That's a shame if it's just to support one tool 😞

It looks like k6 doesn't publish the aarch64 builds at all in the deb or rpm packages. This comment outlines a method for building k6 for aarch64, which we could use to avoid macOS folks needing to run ov under Rosetta.

@dhruvkb I leave it up to you. This PR is at the very least a suitable hot-fix, even if the long term solution avoids Rosetta. I'm particularly worried how this will hurt battery life for y'all on macOS, I've heard Rosetta can be rather battery hungry.

@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 16, 2024

I'll go ahead and merge this to unblock contributors, and open an issue to switch to the using the release assets and avoid Rosetta.

@dhruvkb dhruvkb merged commit 6b5a19c into main Sep 16, 2024
69 of 73 checks passed
@dhruvkb dhruvkb changed the title Specify platform to fix ov builds on macOS Specify amd64 platform to fix ov builds on macOS Sep 16, 2024
@dhruvkb dhruvkb deleted the fix_ov_builds branch September 16, 2024 09:52
@dhruvkb dhruvkb mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@obulat obulat Awaiting requested review from obulat obulat is a code owner automatically assigned from WordPress/openverse-maintainers

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: mgmt Related to repo management and automations
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run ov build
3 participants
@dhruvkb @sarayourfriend @openverse-bot